They mention a new dependency on tzdata, was that something we needed to include?

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355279

x86_64-linux

VM seems to run fine

(i assume my ip is blacklisted, since my instance in known by some)

They mention a new dependency on tzdata, was that something we needed to include?

Judging by this line

https://github.com/iv-org/invidious/blob/98926047586154269bb269d01e3e52e60e044035/docker/Dockerfile#L36

it seems it is needed at runtime, not build time. In my minimal VM i find

But it would be nice to encode this explicitly in the nixos module if possible

Should I simply add it to buildInputs? I guess it worked on my system because tzdata must be installed already (which should be the case for most systems). But apparently alpine based docker is not one of them.

I honestly don't know, many tzdata usages in nixpkgs seem to also involve patching in zoneinfo paths.

According to the bug report it should be obvious enough in the logs if it turns out to be necessary. Requires navigating to the subscriptions page.

So we can go ahead, as it will fix invidious on most systems. If tzdata problems appear, we can address it in a separate pr. I don't know a good way to reproduce the potential bug anyway.

Deployed on aarch64 and fixes the issues mentioned.

Successfully created backport PR for release-24.05:

• [Backport release-24.05] invidious: 2.20240825.2 -> 2.20241110.0 #355420